Repository navigation
Remove anchoredFieldDropdowns flag - #106084
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@ikevin127 @thelullabyy One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
trjExpensify
left a comment
There was a problem hiding this comment.
Excited for it! #105596 <-- let's make sure that gets through to prod first. 👍
|
This can come off hold now. Conflicts to fix! |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-11-09.at.19.09.44.mov |
ikevin127
left a comment
There was a problem hiding this comment.
Request changes (no code blockers): please fill in the PR description. Explanation, Tests and Screenshots are all empty. These are important especially tests since the PR is missing [NoQA] from title which means QA expects testing steps once this is merged.
cc @DylanDylann
puneetlath
left a comment
There was a problem hiding this comment.
The code changes look good to me, but can you update the PR template? I think it may be copied from another PR, because it is mentioning unrelated things like CategoryPickerModal and tests/unit/components/ExpenseFieldDropdown.test.tsx.
Also, can you add an "explanation of change".
And also, I don't think it needs to be No QA. We could still QA this by making sure that the fields we expect to be dropdowns are dropdowns.
|
@puneetlath Updated, thanks for the reminder |
|
Thanks @DylanDylann. Looks like there are conflicts now. |
|
@puneetlath Done |
|
🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.5.37-0 🚀
|
|
No help site update needed — removing the beta changes how expense-field selectors open, but existing articles remain accurate and no documented steps or capabilities change. |
|
Deploy Blocker #106702 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.37-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The anchored dropdowns for
Category, the tag rows,Tax rate,AttendeesandReporton the expense create form were only shown to accounts on theanchoredFieldDropdownsbeta. This PR removes that beta so every account gets them:CONST.BETAS.ANCHORED_FIELD_DROPDOWNS.isBetaEnabledcheck from the five field rows (AttendeeField,CategoryField,ReportField,TagFields,TaxFields).usePermissionsmocks and the "keeps the full-page selector when the beta is off" unit tests.Fixed Issues
$ #101573
PROPOSAL:
Tests
Offline tests
QA Steps
Setup
Wide layout (web/desktop)
anchoredFieldDropdownsis no longer listed.Category. Verify the list opens in a pop-over right below the row, not on a full page. Pick a category and verify the pop-over closes and the row shows it.Tax rate. Verify each row opens its own pop-over and saves the selection.Attendees. Select two attendees and verify the pop-over stays open and the pills update after each tap.Escape. Verify the pop-over closes and focus returns to theAttendeesrow.Report. VerifyNew reportis at the top of the list, then pick a different report.Categoryand verify it opens in a pop-over.Narrow layout (mWeb/native)
11. Repeat steps 2–3. Verify
Categoryopens in a bottom sheet, and that swiping down or tapping the backdrop closes it.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos